Add various TODOs.
authorThomas Mansencal <thomas.mansencal@gmail.com>
Wed, 29 Jul 2015 11:54:59 +0000 (23:54 +1200)
committerThomas Mansencal <thomas.mansencal@gmail.com>
Wed, 29 Jul 2015 11:54:59 +0000 (23:54 +1200)
aces_1.0.0/python/aces_ocio/colorspaces/aces.py
aces_1.0.0/python/aces_ocio/process.py

index e16e5fe..c3e725e 100644 (file)
@@ -737,6 +737,7 @@ def create_ACES_LMT(lmt_name,
         ctls = [os.path.join(aces_ctl_directory,
                              lmt_values['transformCTLInverse']),
                 shaper_from_aces_ctl % aces_ctl_directory]
         ctls = [os.path.join(aces_ctl_directory,
                              lmt_values['transformCTLInverse']),
                 shaper_from_aces_ctl % aces_ctl_directory]
+        # TODO: Investigate unresolved `odt_name` reference.
         lut = 'Inverse.%s.%s.spi3d' % (odt_name, shaper_name)
 
         lut = sanitize(lut)
         lut = 'Inverse.%s.%s.spi3d' % (odt_name, shaper_name)
 
         lut = sanitize(lut)
index 8312ccd..76dd754 100755 (executable)
@@ -41,9 +41,13 @@ def read_text(text_file):
          Return value description.\r
     """\r
 \r
          Return value description.\r
     """\r
 \r
-    if text_file != '':\r
-        with open(text_file, 'rb') as fp:\r
-            text = (fp.read())\r
+    # TODO: Investigate if check is needed.\r
+    if not text_file:\r
+        return\r
+\r
+    with open(text_file, 'rb') as fp:\r
+        text = (fp.read())\r
+\r
     return text\r
 \r
 \r
     return text\r
 \r
 \r
@@ -62,9 +66,13 @@ def write_text(text, text_file):
          Return value description.\r
     """\r
 \r
          Return value description.\r
     """\r
 \r
-    if text_file != '':\r
-        with open(text_file, 'wb') as fp:\r
-            fp.write(text)\r
+    # TODO: Investigate if check is needed.\r
+    if not text_file:\r
+        return\r
+\r
+    with open(text_file, 'wb') as fp:\r
+        fp.write(text)\r
+\r
     return text\r
 \r
 \r
     return text\r
 \r
 \r